Adding HostAccountFields to GMSACredentialSpec objects #47
Conversation
Signed-off-by: Mark Rossetti <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| Scope: contoso.com | ||
| HostAccountConfig: | ||
| PluginGUID: "{GDMA0342-266A-4D1P-831J-20990E82944F}" | ||
| PluginInput: "contoso.com:gmsaccg:<password>" |
There was a problem hiding this comment.
On Azure, the format of PluginInput is ‘ ObjectId=${msiObjectId};SecretUri=${secretUri}’
There was a problem hiding this comment.
This is plugin specific according to https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/manage-serviceaccounts#additional-credential-spec-configuration-for-non-domain-joined-container-host-use-case and this value is a string which means it could be anything. This is an example here but could really be anything the plugin knows how to parse so I think this is ok for the test
There was a problem hiding this comment.
I am not sure whether this plugin supports other input parameters for now 🙂. It should be ok if it is only for test purpose.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AbelHu, jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mark Rossetti [email protected]
Fixes #46
https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/manage-serviceaccounts#additional-credential-spec-configuration-for-non-domain-joined-container-host-use-case for more info on the new fields