fix: handle nil values in field path and update tests #309
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a nil pointer dereference panic that occurs when
GetFromattempts to access fields from embedded structs that are nil pointers. This adds defensive nil checking when traversing field paths to safely return zero values instead of panicking.Problem
The
FieldCacheEntry.GetFrommethod invalue/reflectcache.gotraverses field paths usingFieldByIndexwithout checking if intermediate struct values are nil. When dealing with embedded pointer structs (e.g.,*testBasicStructembedded with,inlinetag), if the pointer is nil, callingFieldByIndexcauses a panic.Example scenario:
Impact