Skip to content

slack-moderator-words: update configs and add to variants.yaml#43

Merged
k8s-ci-robot merged 4 commits intokubernetes-sigs:masterfrom
nikhita:slack-moderator-words-variants
Feb 23, 2021
Merged

slack-moderator-words: update configs and add to variants.yaml#43
k8s-ci-robot merged 4 commits intokubernetes-sigs:masterfrom
nikhita:slack-moderator-words-variants

Conversation

@nikhita
Copy link
Copy Markdown
Member

@nikhita nikhita commented Feb 23, 2021

This PR makes a few changes to slack-moderator-words so we can deploy it.

  • The tool was named as slack-moderate-words in a few places, so updated it to slack-moderator-words for consistency.
  • Updated config files to match the versions we'd deploy to the k8s slack. Specifically, added a configmap for filters.yaml.
  • Added slack-moderator-words to variants.yaml. This will push an image to k8s-staging-slack-infra the next time the post-slack-infra-push-images postsubmit runs.
  • Added slack-moderator-words to the README.

/cc @jeefy @mrbobbytables @cpanato @ameukam
/assign @jeefy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2021
Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@jeefy
Copy link
Copy Markdown
Member

jeefy commented Feb 23, 2021

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Feb 23, 2021

Thank you!! :D

@k8s-ci-robot k8s-ci-robot merged commit 8525eb3 into kubernetes-sigs:master Feb 23, 2021
@nikhita nikhita deleted the slack-moderator-words-variants branch February 23, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants