slack/bot: add moderate words bot#41
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
|
also works in threads |
|
/cc @BenTheElder |
|
/approve This is awesome work, thank you so much! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, jeefy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| spec: | ||
| containers: | ||
| - name: slack-moderator-words | ||
| image: gcr.io/kubernetes-tools/slack-moderator-words:latest |
There was a problem hiding this comment.
version this or add imagePullPolicy: always?
There was a problem hiding this comment.
I forgot always is implicitly/magically the default for containers with image :latest, this is probably my least favorite thing in the API :|
There was a problem hiding this comment.
I think after we merge we will need to update this right? because it might trigger a job to build the images or not?
|
|
||
| type FilterConfig []struct { | ||
| Triggers []string `yaml:"triggers"` | ||
| Action string `yaml:"action"` |
There was a problem hiding this comment.
(Not in this PR) it'd be nice to validate the filter config as a follow up. Example - validate that action is a valid slack action, etc.
There was a problem hiding this comment.
That sounds a good one :)
will do
k8s-ci-robot
added
the
lgtm
| - triggers: | ||
| - guys | ||
| action: chat.postEphemeral | ||
| message: "May I suggest \"all\" instead when addessing a group of people? Thank you. :slightly_smiling_face:" |
There was a problem hiding this comment.
'all' can sound very strange in some sentences depending on how it is used. Its not a 1:1 replacement as sometimes you need to address a subset of people that isn't everyone which all implies. Another recommendation, though an older word, might be 'folks'? (https://www.merriam-webster.com/dictionary/folk, definition 1). I think its a pretty neutral term?
There was a problem hiding this comment.
I don't think this PR is the right place to discuss this kind of thing. Maybe open a new issue or a thread in Slack.
10 participants
Add slack bot service to moderate words in a public channel
Fixes: #27
Right now it is posting ephemeral messages when a word matches the filter config.
We can extend to delete/other actions
/assign @nikhita @jeefy