Mount /dev in cleanup job

[cofyc]

• Update k8s.io/klog to fix bug introduced in stderrthreshold is useless if logtostderr is set kubernetes/klog#31
• Add volume mount configuration in cleanup job Pod spec
• Add e2e test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cofyc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cofyc]

/assign @msau42

1. should discover dynamically created local persistent volume mountpoint in discovery directory is removed, because it gets exercised in should create and recreate local persistent volume already
2. should create and recreate local persistent volume is tested in a matrix to cover more cases

List of current e2e tests:

• [sig-storage] PersistentVolumes-local Local volume provisioner [Serial] should not create local persistent volume for filesystem volume that was not bind mounted
• [sig-storage] PersistentVolumes-local Local volume provisioner [Serial][UseJobForCleaning: true [VolumeType: dir] should create and recreate local persistent volume
• [sig-storage] PersistentVolumes-local Local volume provisioner [Serial][UseJobForCleaning: false][VolumeType: dir] should create and recreate local persistent volume
• [sig-storage] PersistentVolumes-local Local volume provisioner [Serial][UseJobForCleaning: true][VolumeType: block] should create and recreate local persistent volume
• [sig-storage] PersistentVolumes-local Local volume provisioner [Serial][UseJobForCleaning: false][VolumeType: block] should create and recreate local persistent volume
• [sig-storage] PersistentVolumes-local Stress with local volume provisioner [Serial] should use be able to process many pods and reuse local volumes

[msau42]

I'm assuming this doesn't have any issues if we override the container's /dev?

[cofyc]

No, to discover and cleanup we need to mount host /dev into provisioner and cleanup containers.
Potential issue is in certain docker setup program cannot start when host /dev is mounted into container, but provisioner cannot too.

[msau42]

Can you add a comment with a link to the issue?

I assume mounting /dev somewhere else won't work because of symlink resolution issues?

[cofyc]

Updated.

I assume mounting /dev somewhere else won't work because of symlink resolution issues?

Yes

[msau42]

/lgtm