Add waitgroup for worker goroutines in run method#192
Conversation
|
Welcome @rhrmo! |
|
Hi @rhrmo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
16763c0 to
6f1f20c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, rhrmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a wait group for all workers in the controller.go
Run()method. This can be used during shutdown to wait till all the workers are done. We need this for a new featuregate in csi-sidecars for releasing leases right after sigterm/sigint - this would be an example of a merged PR in external-attacher. We need to wait for workers to finish before shutting down a sidecar completely.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: