Skip to content

chore: update golangci-lint to v1.30.0#282

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
olegsu:master
Aug 10, 2020
Merged

chore: update golangci-lint to v1.30.0#282
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
olegsu:master

Conversation

@olegsu
Copy link
Copy Markdown
Contributor

@olegsu olegsu commented Aug 9, 2020 •
edited
Loading

What this PR does / why we need it:
make test never exit

Which issue(s) this PR fixes:
Fixes #281

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 9, 2020

Welcome @olegsu!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 9, 2020

Hi @olegsu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from aramase and ritazh August 9, 2020 11:38
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2020
@aramase
Copy link
Copy Markdown
Member

aramase commented Aug 9, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2020
@olegsu
Copy link
Copy Markdown
Contributor Author

olegsu commented Aug 10, 2020

/retest

@aramase
Copy link
Copy Markdown
Member

aramase commented Aug 10, 2020

/retitle chore: update golangci-lint to v1.30.0

@k8s-ci-robot k8s-ci-robot changed the title update golangci-lint chore: update golangci-lint to v1.30.0 Aug 10, 2020
aramase
aramase reviewed Aug 10, 2020
View reviewed changes
Comment thread Makefile

ifndef HAS_GOLANGCI
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(GOPATH)/bin v1.19.1
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v1.30.0
Copy link
Copy Markdown
Member

@aramase aramase Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the --deadline flag has been replaced with --timeout in the newer version - golangci/golangci-lint#793. Could you also update that as part of this PR?

Copy link
Copy Markdown
Contributor Author

@olegsu olegsu Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, updated also in .golangci.yml file

aramase
aramase reviewed Aug 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@ritazh
Copy link
Copy Markdown
Member

ritazh commented Aug 10, 2020

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olegsu, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit ccaaca6 into kubernetes-sigs:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aramase aramase aramase left review comments

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@aramase aramase

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make test never exit

4 participants

@olegsu @k8s-ci-robot @aramase @ritazh