-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a toggle to disable HTTP/2 on the server to mitigate CVE-2023-44487 #618
Conversation
until the Go standard library and golang.org/x/net are fully fixed.
This issue is currently awaiting triage. If prometheus-adapter contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @machine424! |
Hi @machine424. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
if err != nil { | ||
klog.Fatalf("unable to fetch server: %v", err) | ||
} | ||
server.GenericAPIServer.SecureServingInfo.DisableHTTP2 = cmd.DisableHTTP2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to add an info log for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is necessary since the information is already in the adapter config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, machine424 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes since v0.11.0 Improvements * Register and improve prometheus client http metrics that were previously unregistered (kubernetes-sigs#599, @bogo-y) * Add new flag to disable HTTP/2 (kubernetes-sigs#618, @machine424) * Bump Golang to 1.22.2, Kubernetes libraries to 1.30.0 and other dependencies to their latest version (kubernetes-sigs#659, @dgrisonnet) Bug fixes * Fix multi-arch image build (kubernetes-sigs#601, @dgrisonnet)
Changes since v0.11.0 Improvements * Register and improve prometheus client http metrics that were previously unregistered (kubernetes-sigs#599, @bogo-y) * Add new flag to disable HTTP/2 (kubernetes-sigs#618, @machine424) * Bump Golang to 1.22.2, Kubernetes libraries to 1.30.0 and other dependencies to their latest version (kubernetes-sigs#659, @dgrisonnet) Bug fixes * Fix multi-arch image build (kubernetes-sigs#601, @dgrisonnet) Signed-off-by: Jayapriya Pai <[email protected]>
until the Go standard library and golang.org/x/net are fully fixed.
Manually tested using
curl -sI --http2 -k -w "%{http_version}\n" -o /dev/null https://localhost:6443
(after changing the base image to getcurl
). It returns1.1
when--disable-http2
is set.I could add an e2e test but it'll take some time.