Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis/nfd: allow different types of features of the same name #1671

Merged

source: allow multi-type features

bb565c0
Select commit
Loading
Failed to load commit list.
Merged

apis/nfd: allow different types of features of the same name #1671

source: allow multi-type features
bb565c0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 24, 2024 in 0s

39.60% (target 0.00%)

View this Pull Request on Codecov

39.60% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 84.54545% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 39.60%. Comparing base (c2e3de6) to head (bb565c0).
Report is 39 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   39.84%   39.60%   -0.25%     
==========================================
  Files          80       80              
  Lines        6841     7141     +300     
==========================================
+ Hits         2726     2828     +102     
- Misses       3861     4054     +193     
- Partials      254      259       +5     
Files Coverage Δ
pkg/apis/nfd/nodefeaturerule/rule.go 74.59% <100.00%> (-7.43%) ⬇️
source/source.go 38.33% <ø> (+1.82%) ⬆️
pkg/apis/nfd/nodefeaturerule/expression.go 81.70% <83.16%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes