Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up usage of channels for signaling #1656

Merged

Tidy up usage of channels for signaling

26a80cf
Select commit
Loading
Failed to load commit list.
Merged

Tidy up usage of channels for signaling #1656

Tidy up usage of channels for signaling
26a80cf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 5, 2024 in 0s

30.77% (target 0.00%)

View this Pull Request on Codecov

30.77% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 30.77%. Comparing base (275e625) to head (26a80cf).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1656      +/-   ##
==========================================
+ Coverage   30.42%   30.77%   +0.34%     
==========================================
  Files         102      102              
  Lines        9654     9834     +180     
==========================================
+ Hits         2937     3026      +89     
- Misses       6446     6514      +68     
- Partials      271      294      +23     
Files Coverage Δ
pkg/nfd-worker/nfd-worker.go 52.55% <100.00%> (ø)
pkg/nfd-master/nfd-api-controller.go 12.94% <0.00%> (ø)
pkg/nfd-master/nfd-master.go 46.02% <66.66%> (+2.62%) ⬆️
pkg/nfd-topology-updater/nfd-topology-updater.go 2.50% <0.00%> (ø)

... and 2 files with indirect coverage changes