-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support KUBERNETES_MASTER env variable #1654
Conversation
Support (insecure) connections to the Kubernetes API server by setting the KUBERNETES_MASTER environment variable. This is how e.g. kubectl behaves and also matches the error message(s) from client-go package. This patch is targeted for local testing and development.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @ArangoGutierrez @TessaIO |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the patch is " This patch is targeted for local testing and development."
Let's document this behaviour
Hmm, I start to dislike this approach myself 🙄 This was basically added to make the unit tests in #1655 to pass. I try to think another approach to achieve this |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1654 +/- ##
=======================================
Coverage 30.42% 30.43%
=======================================
Files 102 102
Lines 9654 9651 -3
=======================================
Hits 2937 2937
+ Misses 6446 6443 -3
Partials 271 271
|
After sleeping over this 👎 |
@marquiz: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Support (insecure) connections to the Kubernetes API server by setting the KUBERNETES_MASTER environment variable. This is how e.g. kubectl behaves and also matches the error message(s) from client-go package. This patch is targeted for local testing and development.