Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KUBERNETES_MASTER env variable #1654

Closed
wants to merge 1 commit into from

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Apr 4, 2024

Support (insecure) connections to the Kubernetes API server by setting the KUBERNETES_MASTER environment variable. This is how e.g. kubectl behaves and also matches the error message(s) from client-go package. This patch is targeted for local testing and development.

Support (insecure) connections to the Kubernetes API server by setting
the KUBERNETES_MASTER environment variable. This is how e.g. kubectl
behaves and also matches the error message(s) from client-go package.
This patch is targeted for local testing and development.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 4, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Apr 4, 2024

/assign @ArangoGutierrez @TessaIO

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 0ebc0db
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/660eb8036a8f6d0008e1a9f9
😎 Deploy Preview https://deploy-preview-1654--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 4, 2024
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the patch is " This patch is targeted for local testing and development."
Let's document this behaviour

@marquiz
Copy link
Contributor Author

marquiz commented Apr 4, 2024

If the patch is " This patch is targeted for local testing and development."
Let's document this behaviour

Hmm, I start to dislike this approach myself 🙄 This was basically added to make the unit tests in #1655 to pass. I try to think another approach to achieve this
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 30.43%. Comparing base (275e625) to head (0ebc0db).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1654   +/-   ##
=======================================
  Coverage   30.42%   30.43%           
=======================================
  Files         102      102           
  Lines        9654     9651    -3     
=======================================
  Hits         2937     2937           
+ Misses       6446     6443    -3     
  Partials      271      271           
Files Coverage Δ
pkg/utils/kubernetes.go 0.00% <0.00%> (ø)

@marquiz
Copy link
Contributor Author

marquiz commented Apr 5, 2024

After sleeping over this 👎
/close

@k8s-ci-robot
Copy link
Contributor

@marquiz: Closed this PR.

In response to this:

After sleeping over this 👎
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz marquiz deleted the devel/kubeconfig branch April 5, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants