Implements option #3 (npep-187: More protocols support)#347
Conversation
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c347f62 to
fcfa3cd
Compare
npinaeva
left a comment
There was a problem hiding this comment.
i think we are missing +optional or +required tags on most new fields?
I think I fixed all of the instances -- please take a look. |
|
Updated to incorporate all code review feedback. |
ad0a4fc to
f6466fe
Compare
danwinship
left a comment
There was a problem hiding this comment.
One nitpick but I think this is good to go.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Conformance failure is expected at this point until we update kube-network-policies, right? Meaning, this is ready to merge? |
|
Yes, I think so. I have the draft for fixing kube-network-policies as well, so hopefully we can get everything back green very soon. |
@bowei @danwinship is this the reason why the github actions is failing on kube-network-policies? https://github.com/kubernetes-sigs/kube-network-policies/actions?query=e2e_npa |
Changes to implement option #3 for the port matching
Example (from #297)