-
Notifications
You must be signed in to change notification settings - Fork 35
Small fixes to website and adding contributing info #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rahulkjoshi
commented
Jun 8, 2023
- Added section to contributing doc explaining requirements to locally test docs.
- Fixed broken links
- Added diagram to API explanation
- Cross-linked example API objects to user stories
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Welcome @rahulkjoshi! |
Hi @rahulkjoshi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b5feb1c
to
defc26a
Compare
/ok-to-test |
egress: | ||
- action: Pass | ||
to: | ||
- namespaces: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tssurya Discovered this was wrong :) This should be something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other issues you found @tssurya?
Thanks for doing this @rahulkjoshi Just a few questions! |
Poke @rahulkjoshi Can you update this so we can get it in? :) |
Thanks for the poke, I lost some momentum here 🙃 PTAL, I've rebased and addressed the comments. |
- Added section to contributing doc explaining requirements to locally test docs. - Fixed broken links - Added diagram to API explanation - Cross-linked example API objects to user stories
Thanks @rahulkjoshi /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astoycos, rahulkjoshi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |