This repository was archived by the owner on Jun 26, 2023. It is now read-only.
Remove the hack for unserved versions in envtest#1471
Merged
k8s-ci-robot merged 1 commit intokubernetes-retired:masterfrom Apr 12, 2021
Merged
Remove the hack for unserved versions in envtest#1471k8s-ci-robot merged 1 commit intokubernetes-retired:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-retired:masterfrom
Conversation
Fixes 1148. The hack was served as a workaround for the `envtest failure with unserved versions` bug in controller-runtime kubernetes-sigs/controller-runtime#1154 Since the bug is fixed in controller-runtime v0.7 and HNC is now using v0.8.3, we can restore the workaround. Tested by `make test`.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
Contributor
Author
|
/assign @adrianludwin |
yiqigao217
requested review from
adrianludwin and
rjbez17
and removed request for
JimBugwadia and
tashimi
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1148.
The hack was served as a workaround for the
envtest failure with unserved versionsbug in controller-runtime kubernetes-sigs/controller-runtime#1154Since the bug is fixed in controller-runtime v0.7 and HNC is now using
v0.8.3, we can restore the workaround.
Tested by
make test.