-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alternate GVR in ServiceExport and ServiceImport in e2e tests #20
Comments
/help |
@lauralorenz: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign lauralorenz |
Where are the e2e tests that you're trying to run? |
@apelisse : The end to end test exists here : https://github.com/kubernetes-sigs/mcs-api/tree/master/e2etest |
Updating the issue with the findings so far.
Hence its not possible to use the Client set generated by the client-gen to run conformance or end-to-end tests for various vendors who are using MCS API for their implementation of ServiceImports and ServiceExport resources.
We need a way to override the groupName or provide multiple groupNames when generating clientset for multiple groupNames for MCS API so we can run the e2etests and conformance tests for the API using same clients for all vendors. |
where are the e2e tests? |
Vendors today may be using a mirror of the ServiceExport and ServiceImport APIs and today's e2e tests make it impossible for them to run them as conformance tests because the mcsclient is ultimately configured to use the v1alpha1 API whose GVR (group version resource) is hardcoded as
multicluster.x-k8s.io/v1alpha
.As discussed in SIG-MC today 11/15/2022 we'd like to accommodate vendors who may, due to their own API deprecation policy or during active dev, use a mirror of MCS until upstream is GA (GKE being one of these).
Two ways to potentially address this:
Ultimately the schema of the resources should still be the same for conformance.
Here's an example against GKE clusters of the e2e tests failing on this point:
The text was updated successfully, but these errors were encountered: