-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove starlark support #5768
Remove starlark support #5768
Conversation
Signed-off-by: Davanum Srinivas <[email protected]>
/assign @koba1t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@dims However, I think it would be better to remove the three currently deprecated alpha plugins at the same time. |
The results of my investigationAccording to the Kustomize plugin proposal, we can only remove the legacy 'exec' and 'Go' plugins after we move to the beta phase. The proposal says that the 'starlark plugin' will be removed after the transition to beta. However, considering the lack of response to the following issue, we think it is safe to remove it now to cleanup dependencies。 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, koba1t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.4.3` -> `v5.5.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary> ### [`v5.5.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.5.0) [Compare Source](kubernetes-sigs/kustomize@kustomize/v5.4.3...kustomize/v5.5.0) ### Breaking change A starlark support for krm functions was removed to cleanup dependencies. kubernetes-sigs/kustomize#5768 This feature was deprecated 3 years ago and removed because there was no desire to continue using it. kubernetes-sigs/kustomize#5768 (comment) #### Feature [#​5751](kubernetes-sigs/kustomize#5751): Add `--helm-debug` Flag to Kustomize for Enhanced Helm Debugging #### Fix Bugs [#​5458](kubernetes-sigs/kustomize#5458): Sort built-in Namespace kind before CRDs with the same name [#​5745](kubernetes-sigs/kustomize#5745): Add Annotation to Control Inline List Conversion in Kustomize Resources" #### Dependencies [#​5763](kubernetes-sigs/kustomize#5763): Update go 1.22.7 [#​5781](kubernetes-sigs/kustomize#5781): Update kyaml to v0.18.1 [#​5782](kubernetes-sigs/kustomize#5782): Update cmd/config to v0.15.0 [#​5783](kubernetes-sigs/kustomize#5783): Update api to v0.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Helps drop starlark from kubernetes dependencies, also found an issue here #4349 as well