Remove duplication of findBestFitDomain function

[lchrzaszcz]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes a duplication between two functions: findBestFitDomain and findBestFitDomainForSlices. This improvement was suggested in a comment here: https://github.com/kubernetes-sigs/kueue/pull/5353/files/4bfd8844c197791804491904ff032376d2f83975#r2142313188

Which issue(s) this PR fixes:

Related to: #5439

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	702aa42
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/685960f71e942e0008106b66

[k8s-ci-robot]

Hi @lchrzaszcz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mimowo]

/ok-to-test

[mimowo]

/lgtm
/approve
thanks 👍 assuming the tests pass

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: bf07d666d642df2e44ca1c939d8186a5145cc23e

[tenzen-y]

/hold

[tenzen-y]

Suggested change

	type domainStateGetter func(d *domain) int32
	func findBestFitDomainBy(domains []*domain, needed int32, getState domainStateGetter) *domain {
	type domainState func(d *domain) int32
	func findBestFitDomainBy(domains []*domain, needed int32, state domainState) *domain {

Go does not recommend implementing getter and setter. If we want to implement if, we want to avoid getter related names.

[lchrzaszcz]

Thanks for suggesting that. I've renamed the type to remove getter reference.

[tenzen-y]

Thank you
/lgtm
/approve

/hold cancel

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 21df4aa0044cd84ad06fe79f9c50acaac5d20201

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lchrzaszcz, mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cache/OWNERS [mimowo,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment