Skip to content

Conversation

@lchrzaszcz
Copy link
Contributor

@lchrzaszcz lchrzaszcz commented Jun 18, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is a next step after #5353. This PR allows to define slice-level topology only without the main one. Effectively, that means the main topology is unconstrained.

Which issue(s) this PR fixes:

Relates to: #5439

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 18, 2025
@netlify
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit ae7fa2e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6852d7f1ca09f60008e9d159
😎 Deploy Preview https://deploy-preview-5683--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @lchrzaszcz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 18, 2025
@gabesaba
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2025
@mimowo
Copy link
Contributor

mimowo commented Jun 20, 2025

Proposal to make it a bit more readable to users.

/release-note-edit

TAS: make specifying the PodSet topology level optional when 2-level scheduling is used, i.e.
when the PodSet slice topology level is specified with the `kueue.x-k8s.io/podset-slice-required-topology` annotation. 
In that case the scheduling mode for the PodSet level is assumed as "unconstrained".

@mimowo
Copy link
Contributor

mimowo commented Jun 20, 2025

/lgtm
/approve
thanks 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c112b5afccf7a9954df3fb7d4387b35123b031d0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lchrzaszcz, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit f49944e into kubernetes-sigs:main Jun 20, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.13 milestone Jun 20, 2025
@tenzen-y
Copy link
Member

Proposal to make it a bit more readable to users.

/release-note-edit

TAS: make specifying the PodSet topology level optional when 2-level scheduling is used, i.e.
when the PodSet slice topology level is specified with the `kueue.x-k8s.io/podset-slice-required-topology` annotation. 
In that case the scheduling mode for the PodSet level is assumed as "unconstrained".

@mimowo TAS 2 level scheduling mechanisms have not been released yet. So I think we can remove release-note from this PR.

@mimowo
Copy link
Contributor

mimowo commented Jun 20, 2025

Agree, we can drop it entirely

@tenzen-y
Copy link
Member

/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants