Skip to content

Propagate error from TAS request builder #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2025
Merged

Propagate error from TAS request builder #5662

merged 4 commits into from
Jun 20, 2025

Conversation

@lchrzaszcz
Copy link
Contributor

@lchrzaszcz lchrzaszcz commented Jun 16, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is a follow up after #5353. In one of the comments it has been spotted that we are silently ignoring errors from TAS request builder. This PR fixes the issue by refactoring builder and propagating errors.

Which issue(s) this PR fixes:

Related to: #5439

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 16, 2025
@k8s-ci-robot k8s-ci-robot requested review from kannon92 and mimowo June 16, 2025 13:17
@netlify
Copy link

netlify bot commented Jun 16, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 6f84e6c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68502c35c0ace80008f3ff96

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 16, 2025

Hi @lchrzaszcz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2025
@gabesaba
Copy link
Contributor

gabesaba commented Jun 16, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2025
@lchrzaszcz lchrzaszcz changed the title Propagate error from TAS request builder WIP Propagate error from TAS request builder Jun 16, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2025
@lchrzaszcz lchrzaszcz force-pushed the two-level-tas-scheduling-follow-up-2 branch from f967229 to 1f54051 Compare June 16, 2025 14:12
gabesaba
gabesaba reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@gabesaba gabesaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good modulo reverting a small change

pkg/controller/jobs/pod/pod_controller.go Outdated
}

func constructPodSet(p *corev1.Pod) kueue.PodSet {
func constructPodSet(p *corev1.Pod) (*kueue.PodSet, error) {
Copy link
Contributor

@gabesaba gabesaba Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: revert return type change (pointer)?

Copy link
Contributor Author

@lchrzaszcz lchrzaszcz Jun 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Reverted the change and returning zero-value in case of an error.

@gabesaba
Copy link
Contributor

gabesaba commented Jun 16, 2025

/retitle Propagate error from TAS request builder

@k8s-ci-robot k8s-ci-robot changed the title WIP Propagate error from TAS request builder Propagate error from TAS request builder Jun 16, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2025
@gabesaba
Copy link
Contributor

gabesaba commented Jun 16, 2025

/lgtm
/approve

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 16, 2025

LGTM label has been added.

Git tree hash: 1c1253126fc8790af63cf7c2bd2b4254f365fa25

@mimowo
Copy link
Contributor

mimowo commented Jun 20, 2025

/approve
Thanks 👍

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, lchrzaszcz, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 19ce108 into kubernetes-sigs:main Jun 20, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.13 milestone Jun 20, 2025
@lchrzaszcz lchrzaszcz mentioned this pull request Jul 11, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabesaba gabesaba gabesaba left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@gabesaba gabesaba

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.13

Development

Successfully merging this pull request may close these issues.

4 participants

@lchrzaszcz @k8s-ci-robot @gabesaba @mimowo