Skip to content

Two-level scheduling follow up / Improve readability #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Jun 16, 2025
Merged

Two-level scheduling follow up / Improve readability #5660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions pkg/cache/tas_flavor_snapshot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,15 +660,15 @@ func (s *TASFlavorSnapshot) findTopologyAssignment(
}

func getSliceSizeWithSinglePodAsDefault(podSetTopologyRequest *kueue.PodSetTopologyRequest) (int32, string) {
if podSetTopologyRequest != nil && podSetTopologyRequest.PodSetSliceRequiredTopology != nil {
if podSetTopologyRequest.PodSetSliceSize != nil {
return *podSetTopologyRequest.PodSetSliceSize, ""
} else {
return 0, "slice topology requested, but slice size not provided"
}
if podSetTopologyRequest == nil || podSetTopologyRequest.PodSetSliceRequiredTopology == nil {
return 1, ""
}

if podSetTopologyRequest.PodSetSliceSize == nil {
return 0, "slice topology requested, but slice size not provided"
}

return 1, ""
return *podSetTopologyRequest.PodSetSliceSize, ""
}

// Merges two topology assignments keeping the lexicographical order of levelValues
Expand Down Expand Up @@ -928,6 +928,13 @@ func (s *TASFlavorSnapshot) lowerLevelDomains(domains []*domain) []*domain {
return result
}

// This function sorts domains based on a specified algorithm: BestFit or LeastFreeCapacity.
//
// The sorting criteria are:
// - **BestFit**: `sliceState` (descending), `state` (ascending), `levelValues` (ascending)
// - **LeastFreeCapacity**: `sliceState` (ascending), `state` (ascending), `levelValues` (ascending)
//
// `state` is always sorted ascending. This prioritizes domains that can accommodate slices with minimal leftover pod capacity.
func (s *TASFlavorSnapshot) sortedDomains(domains []*domain, unconstrained bool) []*domain {
isLeastFreeCapacity := useLeastFreeCapacityAlgorithm(unconstrained)
result := slices.Clone(domains)
Expand Down