Skip to content

Automated cherry pick of #5325: Fix assumedUsage calculation in TAS #5349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

Automated cherry pick of #5325: Fix assumedUsage calculation in TAS #5349

merged 2 commits into from
May 26, 2025

Conversation

@lchrzaszcz
Copy link
Contributor

@lchrzaszcz lchrzaszcz commented May 26, 2025 •
edited by k8s-ci-robot
Loading

Cherry pick of #5325 on release-0.10.

#5325: Fix assumedUsage calculation in TAS

For details on the cherry pick process, see the cherry pick requests page.

NONE

@lchrzaszcz
Fix assumedUsage calculation in TAS
8f32cab 
Before this change, for each domain present in podset assignment
algorithm was adding total requested resources for the whole podset
instead of resources actually used by the pods assigned to that
domain. This resulted in some workloads with more than 1 podset not
fitting in the topology which should have enough resources to accomodate
that workload.
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone May 26, 2025
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 26, 2025
@netlify
Copy link

netlify bot commented May 26, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit e0358f2
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68344e2b674c4c0008a34665

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 26, 2025

Hi @lchrzaszcz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2025
@lchrzaszcz lchrzaszcz force-pushed the automated-cherry-pick-of-#5325-upstream-release-0.10 branch from 9146a16 to e0358f2 Compare May 26, 2025 11:19
@mimowo
Copy link
Contributor

mimowo commented May 26, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 26, 2025

LGTM label has been added.

Git tree hash: 9cefdd704bb947cfcd7a1ea9870cec635a18bd41

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lchrzaszcz, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 11dd1bf into kubernetes-sigs:release-0.10 May 26, 2025
16 checks passed
@mimowo
Copy link
Contributor

mimowo commented May 26, 2025

It was not a bug in 0.10, this is just a cleanup
/kind cleanup
/remove-kind cleanup
/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 26, 2025

@mimowo: Those labels are not set on the issue: kind/cleanup

In response to this:

It was not a bug in 0.10, this is just a cleanup
/kind cleanup
/remove-kind cleanup
/release-note-edit

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 26, 2025
@lchrzaszcz lchrzaszcz mentioned this pull request Jul 11, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.10

Development

Successfully merging this pull request may close these issues.

3 participants

@lchrzaszcz @k8s-ci-robot @mimowo