fix: Refactor FitInCohort tests #2655

highpon · 2024-07-21T07:38:44Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We sometimes manipulate the internal accounting of ClusterQueue and Cohort snapshots. This is brittle. Quota/Lending Limit/Borrowing Limit/Usage should be set by calling public api methods, or by defining the CQs/Cohorts via API objects, adding to cache, and creating snapshot.

Which issue(s) this PR fixes:

#2502

Special notes for your reviewer:

This PR is part of #2502. Refactor for flavorassigner_test.go will be done in a separate PR.

Does this PR introduce a user-facing change?

NONE

k8s-ci-robot · 2024-07-21T07:38:53Z

Hi @highpon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-07-21T07:39:06Z

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	`21c2d06`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66a10b556c152a0008ae2232

gabesaba

Thanks for doing this cleanup :)

pkg/cache/clusterqueue_test.go

gabesaba · 2024-07-22T07:45:04Z

/ok-to-test

mimowo · 2024-07-23T14:01:44Z

/approve
Leaving lgtm to @gabesaba when the comments are addressed

k8s-ci-robot · 2024-07-23T14:01:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: highpon, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gabesaba

Thank you for diligently addressing all of the comments. Just 2 small ones left

Also in title of PR, please change Cohorot to Cohort

pkg/cache/clusterqueue_test.go

gabesaba · 2024-07-25T08:01:25Z

/lgtm

k8s-ci-robot · 2024-07-25T08:01:30Z

LGTM label has been added.

Git tree hash: c2d5fada254f3c41ea4233bfe46e459471a0e324

* fix: Refactor FitInCohorot tests * fix: delete no-op function * fix: use new method to add usage * fix: to enforce resource group constraint for flavors and resources * fix: consolidated into a single resource group * fix: delete flavorNames * fix: adjusted test cases to align with existing expected conditions * fix: change FlavorResourceQuantitiesFlat value

* Cleanup to use FlavorResourceQuantities.Add in cache (#2696) * fix: Refactor FitInCohort tests (#2655) * fix: Refactor FitInCohorot tests * fix: delete no-op function * fix: use new method to add usage * fix: to enforce resource group constraint for flavors and resources * fix: consolidated into a single resource group * fix: delete flavorNames * fix: adjusted test cases to align with existing expected conditions * fix: change FlavorResourceQuantitiesFlat value * Finish flattening of FlavorResourceQuantities (#2721) * Finish Flattenning FlavorResourceQuantities * Rename FlavorResourceQuantitiesFlat to FlavorResourceQuantities * Cleanup preemption.go (#2800) * [Partial Admission] Check Mode before attempting Preemption (#2809) * Prefer Reclamation to Priority Based Preemption (#2811) --------- Co-authored-by: s-shiraki <[email protected]>

* fix: Refactor FitInCohorot tests * fix: delete no-op function * fix: use new method to add usage * fix: to enforce resource group constraint for flavors and resources * fix: consolidated into a single resource group * fix: delete flavorNames * fix: adjusted test cases to align with existing expected conditions * fix: change FlavorResourceQuantitiesFlat value

fix: Refactor FitInCohorot tests

37792d0

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2024

k8s-ci-robot requested review from mimowo and trasc July 21, 2024 07:38

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2024

gabesaba reviewed Jul 22, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2024

highpon added 3 commits July 23, 2024 00:22

fix: delete no-op function

6f4af1c

fix: use new method to add usage

6fb30a9

fix: to enforce resource group constraint for flavors and resources

cd25e81

highpon requested a review from gabesaba July 22, 2024 17:07

fix: consolidated into a single resource group

e0b4e74

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024

fix: delete flavorNames

4457656

highpon force-pushed the feat/refactor-FitInCohort-tests branch from 7ba803f to 4457656 Compare July 23, 2024 14:09

fix: adjusted test cases to align with existing expected conditions

9114996

highpon force-pushed the feat/refactor-FitInCohort-tests branch from a4f450b to 9114996 Compare July 23, 2024 16:02

gabesaba reviewed Jul 24, 2024

View reviewed changes

pkg/cache/clusterqueue_test.go Outdated Show resolved Hide resolved

pkg/cache/clusterqueue_test.go Outdated Show resolved Hide resolved

highpon changed the title ~~fix: Refactor FitInCohorot tests~~ fix: Refactor FitInCohort tests Jul 24, 2024

fix: change FlavorResourceQuantitiesFlat value

21c2d06

highpon requested a review from gabesaba July 24, 2024 14:24

k8s-ci-robot assigned gabesaba Jul 25, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024

k8s-ci-robot merged commit b348ce4 into kubernetes-sigs:main Jul 25, 2024

k8s-ci-robot added this to the v0.9 milestone Jul 25, 2024

highpon deleted the feat/refactor-FitInCohort-tests branch July 25, 2024 08:10

highpon mentioned this pull request Jul 30, 2024

REQUEST: New membership for highpon kubernetes/org#5081

Closed

11 tasks

fix: Refactor FitInCohort tests #2655

fix: Refactor FitInCohort tests #2655

Uh oh!

Conversation

highpon commented Jul 21, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

k8s-ci-robot commented Jul 21, 2024

Uh oh!

netlify bot commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Uh oh!

gabesaba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabesaba commented Jul 22, 2024

Uh oh!

mimowo commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 23, 2024

Uh oh!

gabesaba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gabesaba commented Jul 25, 2024

Uh oh!

k8s-ci-robot commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Jul 21, 2024 •

edited

Loading

mimowo commented Jul 23, 2024 •

edited

Loading