roles: rely on configured defaults

[Zakharden]

What type of PR is this?

/kind cleanup

What this PR does / why we need it

This removes a small set of repeated inline defaults from role tasks and templates where Kubespray already defines the same values in role defaults.

The change covers:

• skip_downloads, which is already defined in kubespray_defaults
• download item container, which is already normalized through download_defaults
• dns_timeout and dns_attempts, now defined once in the kubernetes/preinstall role defaults and reused by resolv.conf, NetworkManager, and dhclient templates

This keeps behavior unchanged while reducing duplicated fallback values in the role logic.

Which issue(s) this PR fixes

Fixes part of #11822.

Special notes for your reviewer

This intentionally handles a small, low-risk slice of the broader cleanup requested in #11822 rather than changing every remaining default filter at once.

Does this PR introduce a user-facing change?

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Zakharden / name: Zakhar Dvurechensky (7e4c45b)

[k8s-ci-robot]

Welcome @Zakharden!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Zakharden. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Zakharden]

Could a kubernetes-sigs member please verify this PR for testing when you have a chance?

The change is intentionally scoped to existing role defaults and should be behavior-preserving.
@ErikJiang @mzaian

[guoard]

/ok-to-test

[Zakharden]

/ok-to-test

All tests have been passed, please take a look.🔍

[guoard]

/lgtm

[Zakharden]

@guoard I rebased the PR onto the latest master to resolve the mergeability issue. The change itself is unchanged in scope, and the latest status is green for EasyCLA and yamllint; the external Kubespray CI pipeline is running again after the rebase.

Since the /lgtm label was removed only because the branch was updated, could you please re-check and restore /lgtm when you have a chance?

[guoard]

/lgtm
No need to rebase until there is issue on master which fixed on recent commits.

[Zakharden]

No code changes were introduced in this pass. CI checks are currently green; the remaining block is still in merge queue labels / approve flow.

I have not touched /lgtm as requested; please keep it in place and re-trigger as needed when review state is restored.

[Zakharden]

All requested code changes are in place and CI checks are green. PR currently shows but still has + labels. I have not touched ; if CI rechecks are needed with latest queue state, please rerun them on this PR and proceed.

[Zakharden]

Code is complete and all external checks are green. Merge queue still shows UNSTABLE despite lgtm + ok-to-test labels; I have not touched /lgtm. Please refresh/advance the tide queue when possible.

[guoard]

Some body else needs to approve it.

[yankay]

Nice cleanup @Zakharden! Defaults verified in kubespray_defaults and preinstall. CI green.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay, Zakharden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment