Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --pattern=addon flag that generates an addon operator #846

Closed
wants to merge 1 commit into from

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented Jul 9, 2019

Creates a controller & resource that follow the style of
https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern

These style of declarative addon operators are being investigated in
the cluster-addons subject, with code at
https://github.com/kubernetes-sigs/addon-operators

Creates a controller & resource that follow the style of
https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern

These style of declarative addon operators are being investigated in
the cluster-addons subject, with code at
 https://github.com/kubernetes-sigs/addon-operators
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justinsb
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnsonj
Copy link
Contributor

We discussed this in the kubebuilder and controller-runtime meeting today. @DirectXMan12 is going to take a look and see if the plugin model they've been considering would take care of this use case and propose it if it does.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2019
@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Oct 11, 2019

closing this -- it merged as part of the plugins PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants