Skip to content

✨ chore(tools): bump to k8s v1.26.3#3301

Closed
sozercan wants to merge 2 commits into
kubernetes-sigs:tools-releasesfrom
sozercan:tools-k8s-1262
Closed

✨ chore(tools): bump to k8s v1.26.3#3301
sozercan wants to merge 2 commits into
kubernetes-sigs:tools-releasesfrom
sozercan:tools-k8s-1262

Conversation

@sozercan
Copy link
Copy Markdown

@sozercan sozercan commented Mar 15, 2023 •
edited
Loading

bumps kubebuilder tools to v1.26.3

@sozercan
chore: bump to k8s 1.26.2
be29b27 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 15, 2023

Welcome @sozercan!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 15, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 15, 2023

Hi @sozercan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2023
@sozercan sozercan changed the title chore(tools): bump to k8s v1.26.2 ✨ chore(tools): bump to k8s v1.26.2 Mar 15, 2023
@sozercan sozercan mentioned this pull request Mar 15, 2023
Merged
@sozercan
Copy link
Copy Markdown
Author

sozercan commented Mar 16, 2023

/assign camilamacedo86

rashmigottipati
rashmigottipati reviewed Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sozercan
Once this PR has been reviewed and has the lgtm label, please ask for approval from camilamacedo86. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sozercan sozercan changed the title ✨ chore(tools): bump to k8s v1.26.2 ✨ chore(tools): bump to k8s v1.26.3 Mar 17, 2023
camilamacedo86
camilamacedo86 reviewed Mar 17, 2023
View reviewed changes
Comment thread build/cloudbuild_tools.yaml
# limitations under the License.

substitutions:
_KUBERNETES_VERSION: 1.26.1
Copy link
Copy Markdown
Member

@camilamacedo86 camilamacedo86 Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO update the k8s versions we need to:

  • update controller-runtime and controller-tools (then do new releases)
  • generate an new kubebuilder-tools for it (envtest)
  • update the scaffolds
  • bump the deps above

Copy link
Copy Markdown
Member

@camilamacedo86 camilamacedo86 Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More info: #3054

/hold

Copy link
Copy Markdown
Member

@camilamacedo86 camilamacedo86 Mar 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c/c @rashmigottipati ^

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2023
@sozercan sozercan closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@estroz estroz Awaiting requested review from estroz

@pwittrock pwittrock Awaiting requested review from pwittrock

+1 more reviewer

@rashmigottipati rashmigottipati rashmigottipati left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@camilamacedo86 camilamacedo86

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sozercan @k8s-ci-robot @rashmigottipati @camilamacedo86