Skip to content

✨ bump k8s dependencies to 1.21#2208

Merged
estroz merged 3 commits intokubernetes-sigs:masterfrom
varshaprasad96:bump/k8s-1.21
Jul 1, 2021
Merged

✨ bump k8s dependencies to 1.21#2208
estroz merged 3 commits intokubernetes-sigs:masterfrom
varshaprasad96:bump/k8s-1.21

Conversation

@varshaprasad96
Copy link
Copy Markdown
Member

@varshaprasad96 varshaprasad96 commented Jun 9, 2021

Bump k8s dependencies in kubebuilder binary to 1.21

Signed-off-by: varshaprasad96 varshaprasad96@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 9, 2021
@varshaprasad96
Copy link
Copy Markdown
Member Author

varshaprasad96 commented Jun 9, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 9, 2021
@varshaprasad96
Copy link
Copy Markdown
Member Author

varshaprasad96 commented Jun 9, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@estroz
Copy link
Copy Markdown

estroz commented Jun 9, 2021

@varshaprasad96 go/v3 projects need to use controller-runtime v0.9.0 too.

@varshaprasad96
Copy link
Copy Markdown
Member Author

varshaprasad96 commented Jun 9, 2021 •
edited
Loading

@estroz since there is a pr open on bumping controller-tools version, wasn't sure if it would be done there. Can that be done in a follow up PR?

@Birdrock
Copy link
Copy Markdown
Contributor

Birdrock commented Jun 9, 2021

@varshaprasad96 I can update my PR (#2200) to keep up to date with versions, if that helps.

@varshaprasad96
Copy link
Copy Markdown
Member Author

varshaprasad96 commented Jun 10, 2021

@Birdrock sure, anything works. If you would like to have 2 separate PRs, then we can have k8s 1.21 bump separately. Since #2200 is approved, we can merge that first. i'll rebase this one.

camilamacedo86
camilamacedo86 reviewed Jun 10, 2021
View reviewed changes
@estroz
Copy link
Copy Markdown

estroz commented Jun 10, 2021

@varshaprasad96 I'd rather all k8s deps be updated in the same PR.

@varshaprasad96
Copy link
Copy Markdown
Member Author

varshaprasad96 commented Jun 10, 2021

yep, I'll bump the dependencies in plugin here.

@estroz estroz mentioned this pull request Jun 10, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
@varshaprasad96
Copy link
Copy Markdown
Member Author

varshaprasad96 commented Jun 22, 2021

/hold
this is blocked by kubernetes-sigs/kubebuilder-declarative-pattern#160

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2021
@varshaprasad96 varshaprasad96 mentioned this pull request Jun 29, 2021
Closed
@varshaprasad96
✨ bump k8s dependencies to 1.21
3b251ce 
Bump k8s dependencies in kubebuilder binary to 1.21

Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
@varshaprasad96
update testdata
66a0311
@varshaprasad96
Copy link
Copy Markdown
Member Author

varshaprasad96 commented Jun 30, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@varshaprasad96
Copy link
Copy Markdown
Member Author

varshaprasad96 commented Jun 30, 2021

@estroz @camilamacedo86 - the PR is ready for review

estroz
estroz reviewed Jun 30, 2021
View reviewed changes
@varshaprasad96
bump kb declarative pattern and update dependencies
3a2b80b 
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
@varshaprasad96 varshaprasad96 requested a review from estroz July 1, 2021 00:03
@estroz
Copy link
Copy Markdown

estroz commented Jul 1, 2021

/retest

@estroz
Copy link
Copy Markdown

estroz commented Jul 1, 2021

/override APIDiff
/approve
/lgtm

I'll likely have to force merge this since I don't think overrides will work on action runs.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 1, 2021

@estroz: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • APIDiff

Only the following contexts were expected:

  • netlify/kubebuilder/deploy-preview
  • pull-kubebuilder-e2e-k8s-1-14-10
  • pull-kubebuilder-e2e-k8s-1-15-12
  • pull-kubebuilder-e2e-k8s-1-16-15
  • pull-kubebuilder-e2e-k8s-1-17-11
  • pull-kubebuilder-e2e-k8s-1-18-8
  • pull-kubebuilder-e2e-k8s-1-19-4
  • pull-kubebuilder-test
  • tide
Details

In response to this:

/override APIDiff
/approve
/lgtm

I'll likely have to force merge this since I don't think overrides will work on action runs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@estroz estroz merged commit 1831527 into kubernetes-sigs:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@estroz estroz Awaiting requested review from estroz

Assignees

@estroz estroz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@varshaprasad96 @estroz @Birdrock @k8s-ci-robot @camilamacedo86