Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Export config machinery #2083

Merged
merged 1 commit into from
Mar 15, 2021
Merged

🌱 Export config machinery #2083

merged 1 commit into from
Mar 15, 2021

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Mar 10, 2021

I don't think that this PR has any breaking changes

Closes: #2056
Blocked by: #2080

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 10, 2021
@Adirio
Copy link
Contributor Author

Adirio commented Mar 10, 2021

/test all

This was referenced Mar 11, 2021
Closed
Merged
@Adirio
Store abstraction for persisting Config
f7ad796 
- Store interface and YAML implementation for current usage
- Use PreRunE and PostRunE functions to handle configuration file loading and saving

Signed-off-by: Adrian Orive <[email protected]>
@Adirio Adirio marked this pull request as ready for review March 14, 2021 20:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2021
@Adirio Adirio mentioned this pull request Mar 15, 2021
Closed
camilamacedo86
camilamacedo86 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blocked pr #2080 is merged. It is not a breaking change and it shows currently a requirement for we better address 1.5 plugin implementation and remove its duplication on SDK side.

Also, it was discussed in the meetings and no objections were raised.

So, I am ok with this one. Thank you for the collab 🥇

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Adirio,camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cd8812d into kubernetes-sigs:master Mar 15, 2021
@Adirio Adirio deleted the export-config-machinery branch March 15, 2021 10:53
@varshaprasad96 varshaprasad96 mentioned this pull request Jun 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@droot droot Awaiting requested review from droot

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Export config file schafolding machinery
3 participants
@Adirio @k8s-ci-robot @camilamacedo86