🌱 Move the internal machinery utils to appropiate exported packages #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Adirio
commented
Mar 9, 2021
| @@ -24,6 +24,96 @@ import ( | |||
| "strings" | |||
| ) | |||
|
|
|||
| const ( | |||
| goVerPattern = `^go(?P<major>[0-9]+)\.(?P<minor>[0-9]+)(?:\.(?P<patch>[0-9]+)|(?P<pre>(?:alpha|beta|rc)[0-9]+))?$` | |||
There was a problem hiding this comment.
Regular expression decomposition with comprehensive test suite: https://regex101.com/r/TxisR1/1
14 tasks
camilamacedo86
approved these changes
Mar 10, 2021
- Go version checks and go-modules-based repo discovery moved to pkg/plugins/golang - Command execution and user prompt moved to pkg/plugin/util Signed-off-by: Adrian Orive <[email protected]>
Adirio
force-pushed
the
export-machinery-utils
branch
from
6bb8c0f to
2687774
Compare
camilamacedo86
approved these changes
Mar 10, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial: #2036