-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add the rest of the missing fields and stabilize config v3 #1968
Conversation
Skipping CI for Draft Pull Request. |
1c54080
to
9797cf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shows great for me 🥇
I added just a few nits.
@estroz wdyt?
Signed-off-by: Adrian Orive Oneca <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86, irvifa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice work, this lgtm! |
This PR has been addressing the changes in the PROJECT file which has been discussed for a while and that we reach a consensus. Also, I have been adding this PR for all week in the Slack channel to see if someone has some objection. It has 3 oks already then, it shows good enough to get merged: /lgtm PS.:See that the PR #1869 adds the same fields and also was approved by @estroz as well in the past. The reason for the old pr not get merged was the discussions regards the model changes which now are addressed properly via the PR; #1911. |
Create the v3 config implementation that includes all missing fields.
Closes: #1772
Closes: #1826
Closes: #1959