Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add copyright and license to scaffolded webhook suite test file (go/v3-alpha ) #1758

Merged

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Oct 30, 2020

Description

Add copyright and license to scaffolded webhook suite test file that was previously lacking it.

Motivation

The file had the BoilerplateMixin needed to add the copyright and license but was not being scaffolded with it. As it is just a comment, I think we can consider this not-breaking even if previously scaffolded test suites may not be updated.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2020
@prafull01
Copy link
Contributor

prafull01 commented Oct 30, 2020

@Adirio Good catch 👍 . I missed it

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catcher 👍

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit bf3b3b4 into kubernetes-sigs:master Oct 30, 2020
@camilamacedo86 camilamacedo86 changed the title ✨ Add copyright and license to scaffolded webhook suite test file ✨ Add copyright and license to scaffolded webhook suite test file (go/v3-alpha ) Oct 30, 2020
@Adirio Adirio deleted the webhook-suite-test-copyright branch October 30, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants