plugins: change project name config tag, add pkg/model/file.ProjectNameMixin
#1609
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pkg/model/file/mixins.go
Outdated
| // InjectProjectName implements HasProjectName. | ||
| func (m *ProjectNameMixin) InjectProjectName(projectName string) { | ||
| if m.ProjectName == "" { | ||
| m.ProjectName = strings.ToLower(projectName) |
There was a problem hiding this comment.
Do we really want to be calling strings.ToLower at this point? This might be confusing to someone seeing projectName: MyProject in their PROJECT file and then seeing myproject in their scaffolded files.
There was a problem hiding this comment.
Do we have any concept of PROJECT file validation anywhere?
There was a problem hiding this comment.
I'm fine with always lowercasing projectName.
There was a problem hiding this comment.
Do we have any concept of PROJECT file validation anywhere
No. This file is assumed to be more or less "valid" after init.
the Config.ProjectName into any structs that embed this mixin.
estroz
force-pushed
the
feature/project-name-mixin
branch
from
2104134
to
f028d0a
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This PR adds
pkg/model/file.ProjectNameMixin, which will inject theConfig.ProjectNameinto any structs that embed this mixin./cc @joelanford @pwittrock