Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add versions information to the contribution guidelines #1528

Merged
merged 1 commit into from
May 30, 2020
Merged

doc: add versions information to the contribution guidelines #1528

merged 1 commit into from
May 30, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 27, 2020 •
edited
Loading

closes: #1519

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2020
@camilamacedo86
Copy link
Member Author

/assign @estroz
/assign @hasbro17
/assign @joelanford
/assign @mengqiy

@camilamacedo86 camilamacedo86 force-pushed the add-doc-versions branch 5 times, most recently from 13df241 to 8bce380 Compare May 27, 2020 14:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2020
DirectXMan12
DirectXMan12 requested changes May 29, 2020
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for grammar and content. Suggestions on grammar plus a few additions on content. I probably flubbed a couple of version strings (e.g. used vX instead of just X or X.Y.Z), so double check that on my suggestions ;-).

Overall content is good, though.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2020
@camilamacedo86 camilamacedo86 force-pushed the add-doc-versions branch 4 times, most recently from 06d20b3 to 56f700f Compare May 29, 2020 11:38
camilamacedo86
camilamacedo86 commented May 29, 2020
View reviewed changes
@camilamacedo86 camilamacedo86 force-pushed the add-doc-versions branch 2 times, most recently from b9480f9 to 45b257b Compare May 29, 2020 15:05
@camilamacedo86 camilamacedo86 mentioned this pull request May 29, 2020
Merged
djzager
djzager reviewed May 29, 2020
View reviewed changes
Copy link

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few comments.

@camilamacedo86 camilamacedo86 requested a review from djzager May 29, 2020 23:07
@camilamacedo86
Copy link
Member Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 30, 2020
djzager
djzager approved these changes May 30, 2020
View reviewed changes
Copy link

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit d99d6d5 into kubernetes-sigs:master May 30, 2020
@camilamacedo86 camilamacedo86 deleted the add-doc-versions branch May 30, 2020 02:29
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@Adirio Adirio Awaiting requested review from Adirio

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@djzager djzager

@joelanford joelanford

@mengqiy mengqiy

@hasbro17 hasbro17

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add in the contribution guide purpose of versions
8 participants
@camilamacedo86 @k8s-ci-robot @DirectXMan12 @djzager @joelanford @mengqiy @hasbro17 @estroz