Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS_ALIASES #1296

Closed
wants to merge 2 commits into from
Closed

Update OWNERS_ALIASES #1296

wants to merge 2 commits into from

Conversation

gerred
Copy link

@gerred gerred commented Jan 10, 2020

Active on controller runtime, want to make sure I'm active here too. Going for the bold move of maintainer - happy to change this to reviewer.

Active on controller runtime, want to make sure I'm active here too. Going for the bold move of maintainer - happy to change this to reviewer.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gerred
To complete the pull request process, please assign mengqiy
You can assign the PR to them by writing /assign @mengqiy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Adirio

This comment has been minimized.

@gerred
Copy link
Author

gerred commented Jan 10, 2020

Thanks @Adirio - stuck between a rock and a hard place. I'll review #1288 in the meantime.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gerred,

I am not sure if you have the opportunity to check the doc. It has a process that needs to be followed in order to become a member and then reviewer, and the approver.

I am afraid that we cannot add us as maintainers directly.

@gerred
Copy link
Author

gerred commented Jan 10, 2020

Thanks @camilamacedo86 👍 - I will adjust.

@DirectXMan12
Copy link
Contributor

needs rebase to merge properly otherwise fine I think

@k8s-ci-robot
Copy link
Contributor

@gerred: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020
@DirectXMan12
Copy link
Contributor

@gerred I'd also prefer to see a few more reviews here first, if you can
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2020
@gerred
Copy link
Author

gerred commented Feb 1, 2020

@DirectXMan12 Absolutely 👍. What wasn't clear when I opened this was if we were grouping these all across the entire subproject rather than on a per-repo basis, and based on what we talked about, it makes much more sense about having a consistent set of reviewers/approvers per project. I think there's enough to do over in CR that I'll focus there for now, and if my help can be useful over on this side and in CT, I can always open this PR again.

I'll close for now. :)

@gerred gerred closed this Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants