-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OWNERS_ALIASES #1296
Update OWNERS_ALIASES #1296
Conversation
Active on controller runtime, want to make sure I'm active here too. Going for the bold move of maintainer - happy to change this to reviewer.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gerred The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @camilamacedo86 👍 - I will adjust. |
needs rebase to merge properly otherwise fine I think |
@gerred: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gerred I'd also prefer to see a few more reviews here first, if you can |
@DirectXMan12 Absolutely 👍. What wasn't clear when I opened this was if we were grouping these all across the entire subproject rather than on a per-repo basis, and based on what we talked about, it makes much more sense about having a consistent set of reviewers/approvers per project. I think there's enough to do over in CR that I'll focus there for now, and if my help can be useful over on this side and in CT, I can always open this PR again. I'll close for now. :) |
Active on controller runtime, want to make sure I'm active here too. Going for the bold move of maintainer - happy to change this to reviewer.