Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webhook marker docs #4009

Closed
davidxia opened this issue Jul 10, 2024 · 2 comments · Fixed by #4010
Closed

update webhook marker docs #4009

davidxia opened this issue Jul 10, 2024 · 2 comments · Fixed by #4010
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@davidxia
Copy link
Contributor

What broke? What's expected?

The webhook markers doc doesn't have url even though recent versions of kubebuilder supports it. Does this page need to be refreshed or regenerated from the Golang source in some way?

Reproducing this issue

Latest kubebuilder release 4.1.0 uses controller-tools 0.15.0 which supports the path marker. But the webhook marker doc page doesn't mention it.

KubeBuilder (CLI) Version

4.1.0

PROJECT version

3

Plugin versions

go.kubebuilder.io/v4

Other versions

go 1.22.2

Extra Labels

/kind documentation

@davidxia davidxia added the kind/bug Categorizes issue or PR as related to a bug. label Jul 10, 2024
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 10, 2024
@camilamacedo86
Copy link
Member

Hi @davidxia

Thank you for raising this one. Just to share:

If someone have a time to look on that please feel free.

@camilamacedo86
Copy link
Member

Acctualy, I think that I found already.
This PR should sort it out: #4010
We will need to update the book-v3 to make the result appears in prod.

camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Jul 11, 2024
…cts for artefact images

This PR update the deps used to generate the data in the docs.
It should update the markers to address kubernetes-sigs#4009

Furthermore, for we are able to move forward here we need to remove the redirect for `https://go.kubebuilder.io/images` and `gcr.io/kubebuilder/thirdparty` which are deprecated and/or no longer used.

We are either adding a note in the in the Artefacts page to clarify that ENV TEST binaries are no longer produced by Kubebuilder and its build and promotion was moved to controller-gen.

Close: kubernetes-sigs#4009
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Jul 11, 2024
…cts for artefact images

This PR update the deps used to generate the data in the docs.
It should update the markers to address kubernetes-sigs#4009

Furthermore, for we are able to move forward here we need to remove the redirect for `https://go.kubebuilder.io/images` and `gcr.io/kubebuilder/thirdparty` which are deprecated and/or no longer used.

We are either adding a note in the in the Artefacts page to clarify that ENV TEST binaries are no longer produced by Kubebuilder and its build and promotion was moved to controller-gen.

Close: kubernetes-sigs#4009
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Jul 11, 2024
…cts for artefact images

This PR update the deps used to generate the data in the docs.
It should update the markers to address kubernetes-sigs#4009

Furthermore, for we are able to move forward here we need to remove the redirect for `https://go.kubebuilder.io/images` and `gcr.io/kubebuilder/thirdparty` which are deprecated and/or no longer used.

We are either adding a note in the in the Artefacts page to clarify that ENV TEST binaries are no longer produced by Kubebuilder and its build and promotion was moved to controller-gen.

Close: kubernetes-sigs#4009
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this issue Jul 11, 2024
…cts for artefact images

This PR update the deps used to generate the data in the docs.
It should update the markers to address kubernetes-sigs#4009

Furthermore, for we are able to move forward here we need to remove the redirect for `https://go.kubebuilder.io/images` and `gcr.io/kubebuilder/thirdparty` which are deprecated and/or no longer used.

We are either adding a note in the in the Artefacts page to clarify that ENV TEST binaries are no longer produced by Kubebuilder and its build and promotion was moved to controller-gen.

Close: kubernetes-sigs#4009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
3 participants