-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install-anp.yaml #101
Conversation
don't use the default queue number to avoid conflict with kindnet
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -80,7 +80,7 @@ spec: | |||
- name: kube-network-policies | |||
image: registry.k8s.io/networking/kube-network-policies:v0.6.0 | |||
command: ["/bin/netpol"] | |||
args: ["-v=2", "-admin-network-policy=true", "-baseline-admin-network-policy=true","--hostname-override=$(MY_NODE_NAME)"] | |||
args: ["-v=2", "-admin-network-policy=true", "-baseline-admin-network-policy=true","--hostname-override=$(MY_NODE_NAME)","--nfqueue-id=99"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, since default I guess is 0 what kube-net-pol uses will conflict with that kube-net-pol in kind uses so safer to use a custom value..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default is 100
kube-network-policies/cmd/main.go
Line 44 in d3eeb55
flag.IntVar(&queueID, "nfqueue-id", 100, "Number of the nfqueue used") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so kube-net-pol in KIND uses 100 and hence the conflict... when we install it separately.. I see
/lgtm |
don't use the default queue number to avoid conflict with kindnet