Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-anp.yaml #101

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update install-anp.yaml #101

merged 1 commit into from
Oct 22, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Oct 22, 2024

don't use the default queue number to avoid conflict with kindnet

don't use the default queue number to avoid conflict with kindnet
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2024
@@ -80,7 +80,7 @@ spec:
- name: kube-network-policies
image: registry.k8s.io/networking/kube-network-policies:v0.6.0
command: ["/bin/netpol"]
args: ["-v=2", "-admin-network-policy=true", "-baseline-admin-network-policy=true","--hostname-override=$(MY_NODE_NAME)"]
args: ["-v=2", "-admin-network-policy=true", "-baseline-admin-network-policy=true","--hostname-override=$(MY_NODE_NAME)","--nfqueue-id=99"]
Copy link

@tssurya tssurya Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, since default I guess is 0 what kube-net-pol uses will conflict with that kube-net-pol in kind uses so safer to use a custom value..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is 100

flag.IntVar(&queueID, "nfqueue-id", 100, "Number of the nfqueue used")

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so kube-net-pol in KIND uses 100 and hence the conflict... when we install it separately.. I see

@tssurya
Copy link

tssurya commented Oct 22, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8f07fde into main Oct 22, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants