feat: add enum support in marker type#337
Closed
AkashKumar7902 wants to merge 1 commit intokubernetes-sigs:mainfrom
Closed
feat: add enum support in marker type#337AkashKumar7902 wants to merge 1 commit intokubernetes-sigs:mainfrom
AkashKumar7902 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Author
|
@a-hilaly PTAL! |
a-hilaly
reviewed
Mar 5, 2025
Member
a-hilaly
left a comment
a-hilaly
left a comment
There was a problem hiding this comment.
Thank you @AkashKumar7902 ! left a few comments in-line
Comment on lines
+218
to
+219
| default: | ||
| enumVal = []byte(v) |
Member
There was a problem hiding this comment.
Not sure if we should allow non integer/string values for now
Comment on lines
+214
to
+217
| case "string": | ||
| enumVal = []byte(fmt.Sprintf("\"%s\"", v)) | ||
| case "integer", "number": | ||
| enumVal = []byte(v) |
Member
There was a problem hiding this comment.
Can we perform some validation here? thinking "strconv" to check whether the enumVal is indeed a number of integer
Member
There was a problem hiding this comment.
Can we add some unit tests for enums cases in this package?
Member
|
ping @AkashKumar7902 are you still working onthis? |
Author
|
@a-hilaly I am caught up with some other work. You can assign this to someone else if this is an urgent deliverable. |
|
@a-hilaly Can i pick this issue? |
Member
|
We have #424 addressing this. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #304