Set new GOPATH env var to github actions #491
Conversation
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
=======================================
Coverage 56.47% 56.47%
=======================================
Files 19 19
Lines 926 926
=======================================
Hits 523 523
Misses 350 350
Partials 53 53Continue to review full report at Codecov.
|
|
Could $() work instead of backticks? |
@ahmetb |
It is not necessary, that |
|
Is there a way to augment PATH for all steps? Maybe go path is always at $HOME/go/bin just like the default. |
k8s-ci-robot
added
size/XS
@ahmetb |
|
@alonyb that looks perfect tbh and makes the steps easier. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, alonyb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| set -euo pipefail | ||
| echo "##[set-env name=GOPATH;]$(dirname $GITHUB_WORKSPACE)" | ||
| echo "##[add-path]$(dirname $GITHUB_WORKSPACE)/bin" | ||
| - name: Add GOPATH |
There was a problem hiding this comment.
This name seems wrong to me.
GOPATH is already set but we're adding its bin to PATH.
There was a problem hiding this comment.
Yeah the name could be better like Add GOPATH/bin to PATH.
There was a problem hiding this comment.
sent #493, let me know what you think.
This fixes the old way to set GOPATH to PATH.
This way is used by Minikube too.
I tested it and it works perfectly. logs