Migrate to GitHub workflows for CI

[alonyb]

This PR contain a new CI with github workflows, logs of the pipeline you can check here
Fixes #430

[k8s-ci-robot]

Welcome @RubenBaez!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[ahmetb]

Looks clean I like it!

[corneliusweig]

Yeah, after applying the comments by @ahmetb, this looks good to go.

Let's first run this alongside travis, before we disable it.

We also need to ensure that prow does not merge before GH actions has succeeded, when the auto-approver bot was faster than the CI build.

/retitle Migrate to GitHub workflow
@RubenBaez Can you add Fixes #430 to the PR description?

[ahmetb]

We also need to ensure that prow does not merge before GH actions has succeeded, when the auto-approver bot was faster than the CI build.

That's valid, but with GH actions, GH actually knows there's a "check" much faster than Travis posting back something. So I highly doubt that'll be a problem.

We can run side-by-side for a month.

[alonyb]

@ahmetb @corneliusweig
All suggestions were made, anyone else can tell me :)

[corneliusweig]

One more thing, if someone makes a change (push, PR) without changing plugins / *, it will throw an error, I imagine that this should be the behavior.

🤔 why is that? This is not ideal, because there are maintenance PRs from time to time where we don't change any manifest files.

[corneliusweig]

Thanks for all the hard work you have already put into this! I have a few more thought.

[alonyb]

One more thing, if someone makes a change (push, PR) without changing plugins / *, it will throw an error, I imagine that this should be the behavior.

🤔 why is that? This is not ideal, because there are maintenance PRs from time to time where we don't change any manifest files.

@corneliusweig
Because, if git diff shows no differences between files, it throws an err because of this grep -E 'plugins/.*' | tee /dev/stderr | and set -euo pipefail
So, I could put an IF statement or something to validate it and run that step only when there are changes on settings/* and if there are no changes in settings/* I just pass that step. What do you think?

[corneliusweig]

I wonder why this worked on travis..

Anyway, if grep is making problems, then let's get rid of it. Can you try this:

git diff --name-only --diff-filter=AM ${{ github.event.before }} ${{ github.sha }} -- plugins |
   tee /dev/stderr |
   xargs -I _ $HOME/bin/validate-krew-manifest -manifest _

[corneliusweig]

Hey @alonyb, I left some more comments, did you see them?

[alonyb]

Hey @alonyb, I left some more comments, did you see them?

@corneliusweig
I did not see them, sorry, but I already made some changes. Check it :)

[ahmetb]

Looks good. I think we can merge.
Did you test and manifests and observe them fail or pass after being tested?

[alonyb]

Looks good. I think we can merge.
Did you test and manifests and observe them fail or pass after being tested?

@ahmetb
Yes, just one concern, it’s about last step. I think pipeline should run if someone does not change the plugins/* folder, currently if plugins/* is not changed, the pipeline will fail because git diff
What do you think?

[alonyb]

Looks good. I think we can merge.
Did you test and manifests and observe them fail or pass after being tested?

@ahmetb
Yes, just one concern, it’s about last step. I think pipeline should run if someone does not change the plugins/* folder, currently if plugins/* is not changed, the pipeline will fail because git diff
What do you think?

Should I add a new validation for that. Or that is the right way :)

[alonyb]

@ahmetb @corneliusweig
We can merge this PR.

[ahmetb]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, alonyb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[corneliusweig]

Very nice! Thanks a lot for your persistence @alonyb!