fix: windows goss wrong provider on AWS

[mweibel]

What this PR does / why we need it:
Goss for windows builds on AWS didn't work previous this change because the goss configuration expects amazon, not ami.

[k8s-ci-robot]

Hi @mweibel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mweibel]

/sig windows

[jsturtevant]

@codenrhoden do we have a CI job that tests ami's?

/ok-to-test

[jsturtevant]

This matches

image-builder/images/capi/hack/generate-goss-specs.py

Lines 26 to 28 in f245056

	# Define what OS's are supported on which providers
	builds = {'amazon': ['amazon linux', 'centos', 'flatcar', 'ubuntu', 'windows'],
	'azure': ['centos', 'ubuntu', 'windows'],

[jsturtevant]

As well as Linux config

image-builder/images/capi/packer/ami/packer.json

Line 130 in 83b29e1

"PROVIDER": "amazon",

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, mweibel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• images/capi/packer/ami/OWNERS [jsturtevant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codenrhoden]

/test pull-goss-populate

@codenrhoden do we have a CI job that tests ami's?

@jsturtevant Unfortunately, no. We've long been blocked on getting access to AWS credentials through prow. Credentials for image-builder were created a long while back (like over a year), but then we got blocked on something. I can't remember exactly what. cc @kkeshavamurthy An attempt was made with #423, but that never got finished.