Skip to content

Add auditd for Ubuntu#373

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
SanikaGawhane:sg-ubuntu-auditd
Sep 18, 2020
Merged

Add auditd for Ubuntu#373
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
SanikaGawhane:sg-ubuntu-auditd

Conversation

@SanikaGawhane
Copy link
Contributor

Add audit logs for Ubuntu.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @SanikaGawhane. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2020
Copy link
Contributor

@EleanorRigby EleanorRigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All current changes LGTM.
It will be a good idea to also change goss/goss-vars.yaml to account for the audit package in Debian based OS.

@EleanorRigby
Copy link
Contributor

/assign

@EleanorRigby
Copy link
Contributor

/ok-to-test

Verified locally. Audit rules exist. Log directory was recreated and logs were present.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2020
@EleanorRigby
Copy link
Contributor

Will wait for the test to finish once for lgtm

@EleanorRigby
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2020
@frapposelli
Copy link

/approve

1 similar comment
@ncdc
Copy link
Contributor

ncdc commented Sep 18, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frapposelli, ncdc, SanikaGawhane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7e15726 into kubernetes-sigs:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants