Conversation
|
Related to #198 |
5f98d31 to
2532966
Compare
ebcfee2 to
724548e
Compare
f703405 to
cd4de8b
Compare
joaquimrocha
left a comment
There was a problem hiding this comment.
Thanks @sniok . I left a few comments. Overall, I think we can reduce the number of any types we got now.
I found a possible issue with the interaction: if you enable the error filter and you don't have errors (or any filter without results I guess), you end up not seeing anything. Even the breadcrumbs don't show up, so I felt a bit lost.
Another thing to consider, maybe in a future PR: as an alternative to passing the namespace and name (but still supporting both) to each kube resource, I think we could pass the object of the resource itself optionally, and render initially with it, until the item is gathered from the server. This would have the effect of e.g. preloading the last known state of that object, if you already have it from the graph or a list view, and thus it is immediate for the user, instead of them having to wait for the server responses.
frontend/src/components/resourceMap/details/KubeNodeDetails.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/resourceMap/details/GraphNodeDetails.tsx
Outdated
Show resolved
Hide resolved
16ac9a9 to
a955fa8
Compare
|
Resizing the window from medium to large does not seem to trigger it to layout again, and everything remains tiny. Even though probably the layout should change with a wider browser. If I refresh the browser it does seem to redo the layout to fit in the bigger window. Also, sometimes when I click the maximise button it does the layout properly with the bigger window (as apposed to dragging the window to resize or using window management shortcuts). |
|
works pretty solid for both web and app mode, currently have disabled gpu on so some icons may not be the exact same as current for me in app mode, been adding resources and looking at different sizes, seen a few of the same resize issues rene pointed to |
|
^^ echoing the previous comments, seems to work pretty well but there are some concerns when resizing as well as performance-wise (but this may be unrelated, I have noticed the app can be a CPU hog sometimes lately) |
I don't see this as a blocking issue. If the map is zoomed out to fit everything the items will be small, that's expected |
|
Thanks everyone for the review, I've created an issue to keep track of all the non-blocking items here #2519 As we're nearing the release I'd like to minimize amount of big changes here, so let me know if anyone has objections to shipping this as is |
It's an accessibility issue where most people can't read it. |
b155d1f to
cb55d2a
Compare
|
By default it now zooms in to 100%, with top-left origin if things don't fit or centered as before if things fit Fit to view button will fit everything into view Max zoom is now also increased to 200% Here are the changes |
|
Thanks for addressing that default size of text issue. Appreciate it. I would like to say this is a really great accomplishment, and excellent work. 🎉 Especially by Olek (but also you Joaquim, plus Wilder, Grant, Ivelisse, and Chris for all the design work, as well as Vincent & Evangelos). With many weeks of reporting problems, it can feel unending (So, also thanks for putting up with all the wishes and issue reports in these last weeks/months). |
…meter Some views want to use full width of the available page. By default Layout Container will have a max width. New isFullWidth parameter on the route removes max width Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
d03fb3a to
58102ee
Compare
Introduce new resource Map view under /map route Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>





This PR introduces a new Map view under /map route
It displays most of the kubernetes resource as a graph
Implements #198
Description of all the changes in this PR
frontend: Add Map page and route
Introduces new resource Map view under /map route
This is the main commit introducing the map under
src/components/resourceMapfrontend: Allow Routes to take full width, add isFullWidth route parameter
Map needs as much space as possible.
By default Layout Container will have a max width.
New isFullWidth parameter on the route removes max width
Out of scope for this PR:
Testing done