Skip to content

Automated cherry pick of #737: Add NfsExportOptions parsing#770: Refactor duplicate function#774: Disable NFSExportOptions by default#779

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:release-1.6from
hsadoyan:automated-cherry-pick-of-#737-#770-#774-upstream-release-1.6
Feb 6, 2024
Merged

Automated cherry pick of #737: Add NfsExportOptions parsing#770: Refactor duplicate function#774: Disable NFSExportOptions by default#779
k8s-ci-robot merged 3 commits into
kubernetes-sigs:release-1.6from
hsadoyan:automated-cherry-pick-of-#737-#770-#774-upstream-release-1.6

Conversation

@hsadoyan

@hsadoyan hsadoyan commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Cherry pick of #737 #770 #774 on release-1.6.

#737: Add NfsExportOptions parsing
#770: Refactor duplicate function
#774: Disable NFSExportOptions by default

For details on the cherry pick process, see the cherry pick requests page.

Add NfsExportOptions parsing behind a disabled flag

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2024
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @hsadoyan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 22, 2024
@tyuchn

tyuchn commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2024
@hsadoyan hsadoyan changed the title Automated cherry pick of #737: Add NfsExportOptions parsing #770: Refactor duplicate function #774: Disable NFSExportOptions by default [WIP] Automated cherry pick of #737: Add NfsExportOptions parsing#770: Refactor duplicate function#774: Disable NFSExportOptions by default Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@hsadoyan

hsadoyan commented Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@hsadoyan hsadoyan changed the title [WIP] Automated cherry pick of #737: Add NfsExportOptions parsing#770: Refactor duplicate function#774: Disable NFSExportOptions by default Automated cherry pick of #737: Add NfsExportOptions parsing#770: Refactor duplicate function#774: Disable NFSExportOptions by default Feb 6, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2024

@leiyiz leiyiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hsadoyan, leiyiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit eaa6ce7 into kubernetes-sigs:release-1.6 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants