Check for nil waitOp before examining error code

[mattcary]

/kind bug

If the nil check for the waitOp is not done, the driver can panic.

This PR also cleans up some error code handling and does a better job at retrying errors that are transient (although the flakes we're hitting on the e2e test seem to last longer than the two minute retry).

Fix segfault when GCE compute backend fails to wait for an operation.

/assign @msau42

[mattcary]

/retest

[mattcary]

/assign @msau42

I think the test failures are flakes --- we're not seeming to be able to create instances. I'll keep retrying.

/retry

[msau42]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mattcary,msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sunnylovestiramisu]

/retest-required

[mattcary]

Seems to be flaking on creating an HaHA. It's probably a flake, let's see.

/retest

[mattcary]

Hmm, same HdHA provisioning flake. I'll see if I can reproduce, maybe the test needs to be disabled.

[mattcary]

Seems to be a GCP backend problem. I'll just skip the HdHA test while we work that out.

[mattcary]

/retest

[sunnylovestiramisu]

/lgtm

[k8s-ci-robot]

@mattcary: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019	832d894	link	false	/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sunnylovestiramisu]

/retest-required