Skip to content

Enable dynamic disk type selection#2235

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
hajiler:gv-disk-type-selection-branch
Dec 4, 2025
Merged

Enable dynamic disk type selection#2235
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
hajiler:gv-disk-type-selection-branch

Conversation

@hajiler
Copy link
Copy Markdown
Contributor

@hajiler hajiler commented Nov 12, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

This PR enables the dynamic volumes feature, allowing the selection of disk type during CreateVolume depending on what disks are actually supported by the node.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
pdcsi-releaser-new-branch=true

Does this PR introduce a user-facing change?:

Introduce dynamic disk provisioning, automatically selecting a volume's disk type for type based on node compatibility (denoted by`disk-type.gke.io/[disk-type]` node labels).
Action: Required: Add the flag "--dynamic-volumes=true" to the PDCSI controller and node components.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 12, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 12, 2025
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 7377e33 to 0098730 Compare November 12, 2025 18:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 12, 2025
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 0098730 to 0705523 Compare November 12, 2025 23:37
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2025
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 0705523 to 11cfd57 Compare November 14, 2025 19:03
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2025
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 11cfd57 to 237c00b Compare November 17, 2025 20:39
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 17, 2025
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 237c00b to 4aa0554 Compare November 25, 2025 03:47
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 25, 2025
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 4aa0554 to 3111e9d Compare November 25, 2025 03:53
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 25, 2025
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 3111e9d to 796b446 Compare November 25, 2025 05:17
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch 3 times, most recently from b053063 to a04dab4 Compare November 25, 2025 20:09
@hajiler hajiler marked this pull request as ready for review November 25, 2025 22:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2025
Comment thread pkg/gce-pd-csi-driver/controller.go Outdated
Comment thread pkg/gce-pd-csi-driver/controller.go
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from a04dab4 to 3056c25 Compare December 1, 2025 19:21
@cemakd
Copy link
Copy Markdown
Contributor

cemakd commented Dec 1, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2025
Comment thread pkg/gce-pd-csi-driver/disk_selection.go Outdated
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 3056c25 to c132a2c Compare December 3, 2025 21:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2025
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from c132a2c to 31932fb Compare December 3, 2025 21:36
@hajiler hajiler force-pushed the gv-disk-type-selection-branch branch from 31932fb to 49d3444 Compare December 4, 2025 22:03
@mattcary
Copy link
Copy Markdown
Contributor

mattcary commented Dec 4, 2025

e2e failure: W1204 22:11:43.529337 9527 instance.go:234] instance gce-pd-csi-e2e-us-east4-a-n2d-standard-4-0 not in state RUNNING, was REPAIRING

:-/

/retest

@mattcary
Copy link
Copy Markdown
Contributor

mattcary commented Dec 4, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hajiler, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 4, 2025

@hajiler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 49d3444 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit d9cbaf1 into kubernetes-sigs:master Dec 4, 2025
8 of 10 checks passed
@hajiler
Copy link
Copy Markdown
Contributor Author

hajiler commented Dec 5, 2025

/reopen

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hajiler: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants