Skip to content

feat: Instrument node metrics for unexpected device path changes#2193

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
tonyzhc:add-device-path-change-metric
Oct 13, 2025
Merged

feat: Instrument node metrics for unexpected device path changes#2193
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
tonyzhc:add-device-path-change-metric

Conversation

@tonyzhc
Copy link
Copy Markdown
Contributor

@tonyzhc tonyzhc commented Oct 10, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:
Adds a new metric, unexpected_device_path_changes, to track unexpected device path changes. This metric is incremented whenever the device path for a volume changes, as detected by the linkcache's periodic check.

This helps in monitoring and alerting on potentially unstable device paths, which can be an indicator of underlying issues.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a new node server metric `unexpected_device_path_changes` to track unexpected device path changes.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 10, 2025
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Oct 10, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tonyzhc / name: Hanchi Zhang (76d8e7c)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2025
@mattcary
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, tonyzhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@tonyzhc tonyzhc force-pushed the add-device-path-change-metric branch from db2920e to bb0b5dc Compare October 13, 2025 16:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2025
@tonyzhc tonyzhc force-pushed the add-device-path-change-metric branch from bb0b5dc to 94aaf29 Compare October 13, 2025 16:31
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 13, 2025
@tonyzhc tonyzhc force-pushed the add-device-path-change-metric branch 2 times, most recently from 0da88c7 to 2264426 Compare October 13, 2025 17:42
@tonyzhc
Copy link
Copy Markdown
Contributor Author

tonyzhc commented Oct 13, 2025

@mattcary could you LGTM again?

@mattcary
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2025
Adds a new metric, `unexpected_device_path_changes`, to track unexpected device path changes. This metric is incremented whenever the device path for a volume changes, as detected by the linkcache's periodic check.

This helps in monitoring and alerting on potentially unstable device paths, which can be an indicator of underlying issues.
@tonyzhc tonyzhc force-pushed the add-device-path-change-metric branch from 2264426 to 76d8e7c Compare October 13, 2025 20:57
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Oct 13, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@tonyzhc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 2264426 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019
pull-gcp-compute-persistent-disk-csi-driver-e2e-arm 76d8e7c link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-arm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mattcary
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit b57158a into kubernetes-sigs:master Oct 13, 2025
7 of 10 checks passed
@tonyzhc
Copy link
Copy Markdown
Contributor Author

tonyzhc commented Oct 30, 2025

/cherry-pick 1.21

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@tonyzhc: cannot checkout 1.21: error checking out "1.21": exit status 1 error: pathspec '1.21' did not match any file(s) known to git

Details

In response to this:

/cherry-pick 1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tonyzhc
Copy link
Copy Markdown
Contributor Author

tonyzhc commented Oct 30, 2025

/cherry-pick release-1.21

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@tonyzhc: new pull request created: #2223

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants