feat: Instrument node metrics for unexpected device path changes#2193
Conversation
|
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, tonyzhc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
db2920e to
bb0b5dc
Compare
bb0b5dc to
94aaf29
Compare
0da88c7 to
2264426
Compare
|
@mattcary could you LGTM again? |
|
/lgtm |
Adds a new metric, `unexpected_device_path_changes`, to track unexpected device path changes. This metric is incremented whenever the device path for a volume changes, as detected by the linkcache's periodic check. This helps in monitoring and alerting on potentially unstable device paths, which can be an indicator of underlying issues.
2264426 to
76d8e7c
Compare
|
@tonyzhc: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/cherry-pick 1.21 |
|
@tonyzhc: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.21 |
|
@tonyzhc: new pull request created: #2223 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
Adds a new metric,
unexpected_device_path_changes, to track unexpected device path changes. This metric is incremented whenever the device path for a volume changes, as detected by the linkcache's periodic check.This helps in monitoring and alerting on potentially unstable device paths, which can be an indicator of underlying issues.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: