Skip to content

fix: update Hyperdisk attach limits to match GCP documentation for Gen4 machines#2128

Closed
sunnylovestiramisu wants to merge 1 commit into
kubernetes-sigs:masterfrom
sunnylovestiramisu:release-1.20
Closed

fix: update Hyperdisk attach limits to match GCP documentation for Gen4 machines#2128
sunnylovestiramisu wants to merge 1 commit into
kubernetes-sigs:masterfrom
sunnylovestiramisu:release-1.20

Conversation

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Jul 10, 2025 •
edited
Loading

Merge pull request #2127 from arsiesys/fix/hyperdisk-limits

What type of PR is this?
/kind bug

What this PR does / why we need it:
Manual cherry-pick of #2127 because of conflicts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: update Hyperdisk attach limits to match GCP documentation for Gen4 machines

@k8s-ci-robot @sunnylovestiramisu
Merge pull request kubernetes-sigs#2127 from arsiesys/fix/hyperdisk-l…
7540897 
…imits

fix: update Hyperdisk attach limits to match GCP documentation for Gen4
machines
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 10, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2025
@sunnylovestiramisu
Copy link
Copy Markdown
Contributor Author

sunnylovestiramisu commented Jul 10, 2025

/assign @mattcary

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor Author

sunnylovestiramisu commented Jul 10, 2025 •
edited
Loading

Talked offline since there is label override, a slightly lower default should not impact most workloads

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 10, 2025

@sunnylovestiramisu: you cannot LGTM your own PR.

Details

In response to this:

Talked offline since there is label override, a slightly lower default should not impact most workloads
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor Author

sunnylovestiramisu commented Jul 11, 2025

/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 11, 2025

@sunnylovestiramisu: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sunnylovestiramisu sunnylovestiramisu deleted the release-1.20 branch September 24, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julianKatz julianKatz Awaiting requested review from julianKatz

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@mattcary mattcary

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunnylovestiramisu @k8s-ci-robot @mattcary