Change Attach Limit to Hyperdisk Balanced Only

[sunnylovestiramisu]

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Change Attach Limit to Hyperdisk Balanced Only

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sunnylovestiramisu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sunnylovestiramisu]

/hold

[sunnylovestiramisu]

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

[k8s-ci-robot]

@sunnylovestiramisu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e	a75d2d9	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[arsiesys]

Hi,

I believe this fix may introduce side effects since each machine family has different limits. The current approach would only work properly for the N4 family. For better clarity and correctness, we should use different limit maps based on the machine type, with each map containing the specific limits for that family. I'll submit a separate PR that addresses this concern.

[arsiesys]

As mentioned, I created this alternative PR:
#2127

[sunnylovestiramisu]

/close

In favor of #2127

[k8s-ci-robot]

@sunnylovestiramisu: Closed this PR.

Details

In response to this:

/close

In favor of #2127

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.