-
Notifications
You must be signed in to change notification settings - Fork 182
Data cache support for K8s 1.31 #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6ecf0ff
Add support for data cache
Sneha-at 27b866a
fix test suite issue
Sneha-at 02c8534
Update flags for data cache
Sneha-at 8b4d9e1
Add hdMachineType to e2e setup code
cemakd 040ec58
Implementing watcher & reboot stability for data cache to master branch.
halimsam 8f2a701
Return error for any Data Cache related code in NodeStageVolume &
halimsam 4212f84
update RAIDing and validation steps
hungnguyen243 723acf5
update test setup to avoid running Datacache setup on machines not su…
hungnguyen243 e1d8632
update validation logic for Data Cache to distinguish user and non-us…
hungnguyen243 63d56ec
Update error message for end users
sunnylovestiramisu 03d4a84
Fix chunksize bug for large cache size in data cache
Sneha-at bc0a5d3
skip cache clean up for non-data cache PVCs
Sneha-at 5233508
Add unit tests
Sneha-at f86f20d
Only run data cache watcher if a data cache nodepool exist & adding
halimsam 0c33c22
Fix logic bug while checking available LSSDs for RAIDing for Data Cache
hungnguyen243 0cb814a
fix outdated metadata error in watcher
hungnguyen243 9aca35b
update cache logic to calculate chunk size based on toatl cache
Sneha-at 5b9665a
Update
halimsam f04f496
remove GKE Data Cache Watcher regular event logs since it's generating
halimsam a420e9d
Resolving some bad merges, update to e2e test setup, mod vendor update
cemakd 3ffb6af
Fix main.go bad merge from the latest commit hash of Data cache PRs
cemakd f22f043
Check for volume group existing before updating vg metadata
cemakd daa3ff5
Disabling data cache watcher by default if node details are not avail…
cemakd 21a8ece
Fix typo and use strings.Fields for whitespace
cemakd 9ecd66d
Revert the default value for isDataCacheEnabledNodePool to return true
cemakd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| #!/bin/bash | ||
|
|
||
| /bin/cp -r /lvm-tmp/lvm /etc/ | ||
| /bin/sed -i -e "s/.*allow_mixed_block_sizes = 0.*/ allow_mixed_block_sizes = 1/" /etc/lvm/lvm.conf | ||
| /bin/sed -i -e "s/.*udev_sync = 1.*/ udev_sync = 0/" /etc/lvm/lvm.conf | ||
| /bin/sed -i -e "s/.*udev_rules = 1.*/ udev_rules = 0/" /etc/lvm/lvm.conf | ||
| /bin/sed -i -e "s/.*locking_dir = .*/ locking_dir = \"\/tmp\"/" /etc/lvm/lvm.conf | ||
|
|
||
| /gce-pd-csi-driver "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there here just for testing, or do we want to set it back for the current stable-master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value was set to v1.13.2 on the release 1.14 branch per: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/release-1.14/deploy/kubernetes/images/stable-master/image.yaml
One of the PRs I cherry picked most likely set this to a higher value and that's likely why it shows the diff from 1.17.2.
On this release branch I believe it should be set to the release branch's stable master version right?