Skip to content

remove no-op log statement in reduceVolumeGroup for master branch.#2070

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
halimsam:remover-watcher-log
Apr 30, 2025
Merged

remove no-op log statement in reduceVolumeGroup for master branch.#2070
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
halimsam:remover-watcher-log

Conversation

@halimsam
Copy link
Copy Markdown
Contributor

@halimsam halimsam commented Apr 30, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
remove no-op log statement in reduceVolumeGroup for master branch.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2025
@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

sunnylovestiramisu commented Apr 30, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: halimsam, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2025
@halimsam
Copy link
Copy Markdown
Contributor Author

halimsam commented Apr 30, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit a89f221 into kubernetes-sigs:master Apr 30, 2025
7 of 9 checks passed
@halimsam halimsam mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@halimsam @sunnylovestiramisu @k8s-ci-robot