Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HdHA disk provisioning #1915

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tonyzhc
Copy link

@tonyzhc tonyzhc commented Jan 29, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for the PDCSI driver to provision Hyperdisk-balanced High Availability (HdHA) disks. This allows users to use the latest generation of regional disks from GCE. The feature is gated behind flag allow-hdha-provisioning.

Which issue(s) this PR fixes:

Fixes b/391964605

Special notes for your reviewer:

One potential gap I observe is that we have to return the raw GCE error if users call ControllerPublishVolume on a HdHA disk in read only mode, because we cannot determine the disk type without actually fetching the disk. I think this is mostly fine since the GCE error is pretty clear (" Error 400: The disk cannot be attached with READ_ONLY mode."), but please let me know if I should add some more explicit error message.

Does this PR introduce a user-facing change?:

Add support for provisioning Hyperdisk-balanced High Availability disks.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tonyzhc
Once this PR has been reviewed and has the lgtm label, please assign sunnylovestiramisu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @tonyzhc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 29, 2025
@leiyiz
Copy link
Contributor

leiyiz commented Feb 3, 2025

/ok-to-test
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2025
@leiyiz leiyiz requested review from amacaskill and removed request for leiyiz and saikat-royc February 3, 2025 19:03
@tonyzhc
Copy link
Author

tonyzhc commented Feb 3, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 3, 2025

@tonyzhc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e 08bb32f link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants